Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More keys #2277

Closed
Closed

Conversation

AmazingMech2418
Copy link
Contributor

Resolves

#1892

Proposed Changes

This adds the sensing of keys shift and backspace.

Reason for Changes

This will allow projects to use both the backspace key and shift key.

Test Coverage

No tests have been completed, but this is a simple change.

@apple502j
Copy link
Contributor

Huh. Please make issues and get "help wanted" before submitting PRs.

@AmazingMech2418
Copy link
Contributor Author

@apple502j The issue was already created, although it was not labelled "help wanted". This PR simply resolves that issue.

@apple502j
Copy link
Contributor

@amazinigmech2418 That means they don't add it for now.

@Kenny2github
Copy link
Contributor

As an outside contributor, do not open pull requests to resolve issues that are not labelled "help wanted", even if it's a simple fix.
There are design implications to any change, especially changes like this, and the Scratch Team has to consider whether to even make the change before bothering to wonder if they are OK with outside contributors making the change.
Please close this pull request, and only reopen it if #1892 becomes help wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants